ui: pass validated storagepolicy for swift store by shwstppr · Pull Request #11315 · apache/cloudstack

shwstppr · 2025-07-29T03:46:13Z

Description

Fixes #9789

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#9789 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2025-07-29T03:54:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (ca6d2dc) to head (fa6a770).
⚠️ Report is 9 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11315   +/-   ##
=========================================
  Coverage     15.17%   15.18%           
- Complexity    11362    11368    +6     
=========================================
  Files          5415     5415           
  Lines        476030   476032    +2     
  Branches      58115    58116    +1     
=========================================
+ Hits          72246    72263   +17     
+ Misses       395701   395683   -18     
- Partials       8083     8086    +3

Flag	Coverage Δ
uitests	`4.28% <ø> (-0.01%)`	⬇️
unittests	`15.90% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2025-07-29T04:11:43Z

@blueorangutan ui

Copilot

Pull Request Overview

Fixes a bug in the Swift storage configuration by adding validation before passing the storagepolicy parameter. The change prevents passing an empty or undefined storagepolicy value to the Swift store configuration.

Adds conditional validation for the storagepolicy parameter before including it in swiftParams
Prevents potential issues with empty or undefined storagepolicy values being sent to the backend

ui/src/views/infra/AddSecondaryStorage.vue

DaanHoogland

clgtm

sureshanaparti

clgtm

kiranchavala · 2025-07-30T10:35:16Z

@blueorangutan pacakge

DaanHoogland · 2025-07-30T11:30:23Z

@blueorangutan pacakge

sureshanaparti · 2025-07-30T11:38:11Z

@blueorangutan package

blueorangutan · 2025-07-30T11:40:05Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T12:46:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14472

kiranchavala

@shwstppr not a UI issue i believe

When there is no zone id provided to

https://cloudstack.apache.org/api/apidocs-4.20/apis/addImageStore.html


add imagestore provider=Swift name=gh2 details[0].key=account details[0].value=AUTH_test details[1].key=username details[1].value=test:tester details[2].key=key details[2].value=testing url=http://127.0.0.1:8081

🙈 Error: (HTTP 530, error code 9999) <nil>

Logs

2025-07-31 05:31:30,141 DEBUG [c.c.a.ApiServlet] (qtp146370526-19:ctx-25745abc) (logid:cfa196bb) ===START===  10.0.33.30 -- GET  apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=addImageStore&details[0].key=account&details[0].value=AUTH_test&details[1].key=username&details[1].value=test%3Atester&details[2].key=key&details[2].value=testing&name=gh2&provider=Swift&response=json&url=http%3A%2F%2F127.0.0.1%3A8081&signature=VUVzkNEKIHfBWnYEOM8ERNkdT%2FA%3D
2025-07-31 05:31:30,148 DEBUG [c.c.a.ApiServer] (qtp146370526-19:ctx-25745abc ctx-cadf6c05) (logid:cfa196bb) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"12e6ae5d-6dba-11f0-8c3a-1e001e0001b1"}]' is allowed to perform API calls: 0.0.0.0/0,::/0
2025-07-31 05:31:30,154 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp146370526-19:ctx-25745abc ctx-cadf6c05) (logid:cfa196bb) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2025-07-31 05:31:30,156 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp146370526-19:ctx-25745abc ctx-cadf6c05) (logid:cfa196bb) API rate limiting is disabled. We will not use ApiRateLimitService.
2025-07-31 05:31:30,158 INFO  [o.a.c.s.d.l.SwiftImageStoreLifeCycleImpl] (qtp146370526-19:ctx-25745abc ctx-cadf6c05 ctx-895fd978) (logid:cfa196bb) Trying to add a swift store at http://127.0.0.1:8081 in data center null
2025-07-31 05:31:30,197 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] (qtp146370526-19:ctx-25745abc ctx-cadf6c05 ctx-895fd978) (logid:cfa196bb) template 3 is already in store:6, type:Image
2025-07-31 05:31:30,207 DEBUG [o.a.c.s.c.a.StorageCacheRandomAllocator] (qtp146370526-19:ctx-25745abc ctx-cadf6c05 ctx-895fd978) (logid:cfa196bb) Can't find staging storage in zone: null
2025-07-31 05:31:30,211 ERROR [c.c.a.ApiServer] (qtp146370526-19:ctx-25745abc ctx-cadf6c05 ctx-895fd978) (logid:cfa196bb) unhandled exception executing api command: [Ljava.lang.String;@5b26c5a2
java.lang.NullPointerException
	at org.apache.cloudstack.storage.datastore.driver.SwiftImageStoreDriverImpl.createAsync(SwiftImageStoreDriverImpl.java:107)
	at org.apache.cloudstack.storage.image.TemplateServiceImpl.createTemplateAsync(TemplateServiceImpl.java:202)
	at org.apache.cloudstack.storage.image.TemplateServiceImpl.downloadBootstrapSysTemplate(TemplateServiceImpl.java:247)
	at com.cloud.storage.StorageManagerImpl.discoverImageStore(StorageManagerImpl.java:3399)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)

When there is zone id provided

(localcloud) 🐱 > add imagestore provider=Swift name=gh2 details[0].key=account details[0].value=AUTH_test details[1].key=username details[1].value=test:tester details[2].key=key details[2].value=testing url=http://127.0.0.1:8081 zoneid=4e4b9342-fdb6-410f-bc8d-25a107d6a3f6


🙈 Error: (HTTP 431, error code 4350) Image store provider Swift does not support scope ZONE

https://cloudstack.apache.org/api/apidocs-4.20/apis/addSwift.html

(localcloud) 🐱 > add swift url=http://127.0.0.1:8081 username=test:tester account=AUTH_test key=testing
🙈 Error: (HTTP 530, error code 9999) <nil>

2025-07-31 05:33:41,290 DEBUG [c.c.a.ApiServlet] (qtp146370526-18:ctx-7deaced8) (logid:692bcccd) ===START===  10.0.33.30 -- GET  account=AUTH_test&apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=addSwift&key=testing&response=json&url=http%3A%2F%2F127.0.0.1%3A8081&username=test%3Atester&signature=98SLp9zuj9OL1WneGTib4S6w93o%3D
2025-07-31 05:33:41,295 DEBUG [c.c.a.ApiServer] (qtp146370526-18:ctx-7deaced8 ctx-df31b325) (logid:692bcccd) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"12e6ae5d-6dba-11f0-8c3a-1e001e0001b1"}]' is allowed to perform API calls: 0.0.0.0/0,::/0
2025-07-31 05:33:41,300 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp146370526-18:ctx-7deaced8 ctx-df31b325) (logid:692bcccd) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2025-07-31 05:33:41,300 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp146370526-18:ctx-7deaced8 ctx-df31b325) (logid:692bcccd) API rate limiting is disabled. We will not use ApiRateLimitService.
2025-07-31 05:33:41,314 INFO  [o.a.c.s.d.l.SwiftImageStoreLifeCycleImpl] (qtp146370526-18:ctx-7deaced8 ctx-df31b325 ctx-e43d5512) (logid:692bcccd) Trying to add a swift store at http://127.0.0.1:8081 in data center null
2025-07-31 05:33:41,344 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] (qtp146370526-18:ctx-7deaced8 ctx-df31b325 ctx-e43d5512) (logid:692bcccd) template 3 is already in store:6, type:Image
2025-07-31 05:33:41,356 DEBUG [o.a.c.s.i.TemplateDataFactoryImpl] (qtp146370526-18:ctx-7deaced8 ctx-df31b325 ctx-e43d5512) (logid:692bcccd) template 3 is already in store:7, type:Image
2025-07-31 05:33:41,369 DEBUG [o.a.c.s.c.a.StorageCacheRandomAllocator] (qtp146370526-18:ctx-7deaced8 ctx-df31b325 ctx-e43d5512) (logid:692bcccd) Can't find staging storage in zone: null
2025-07-31 05:33:41,375 ERROR [c.c.a.ApiServer] (qtp146370526-18:ctx-7deaced8 ctx-df31b325 ctx-e43d5512) (logid:692bcccd) unhandled exception executing api command: [Ljava.lang.String;@4d138f1d
java.lang.NullPointerException
	at org.apache.cloudstack.storage.datastore.driver.SwiftImageStoreDriverImpl.createAsync(SwiftImageStoreDriverImpl.java:107)
	at org.apache.cloudstack.storage.image.TemplateServiceImpl.createTemplateAsync(TemplateServiceImpl.java:202)
	at org.apache.cloudstack.storage.image.TemplateServiceImpl.downloadBootstrapSysTemplate(TemplateServiceImpl.java:247)
	at com.cloud.storage.StorageManagerImpl.discoverImageStore(StorageManagerImpl.java:3399)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
	at com.sun.proxy.$Proxy108.discoverImageStore(Unknown Source)
	at org.apache.cloudstack.api.command.admin.swift.AddSwiftCmd.execute(AddSwiftCm

Fixes apache#11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-08-04T03:50:40Z

@kiranchavala The error logs shared suggest a different issue than the one originally reported.
From the code, I understand that the Swift secondary store requires an NFS cache store, which is causing the NPE. I couldn’t find much documentation on this.
I've created #11380 to handle the NPE, but in my testing, I wasn’t able to get the SSVM working — even after adding a cache store — as it required seeding the system VM template, which I was unable to do. Though I was able to add the store successfully.

kiranchavala · 2025-08-04T04:47:33Z

@kiranchavala The error logs shared suggest a different issue than the one originally reported. From the code, I understand that the Swift secondary store requires an NFS cache store, which is causing the NPE. I couldn’t find much documentation on this. I've created #11380 to handle the NPE, but in my testing, I wasn’t able to get the SSVM working — even after adding a cache store — as it required seeding the system VM template, which I was unable to do. Though I was able to add the store successfully.

Thanks @shwstppr will test the fix

Fixes #11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Fixes apache#11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Fixes apache#9789 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

ui: pass validated storagepolicy for swift store

fa6a770

Fixes apache#9789 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added the component:UI label Jul 29, 2025

shwstppr mentioned this pull request Jul 29, 2025

Exception is thrown when adding Swift as a secondary storage #9789

Closed

sureshanaparti requested a review from Copilot July 29, 2025 04:11

Copilot AI reviewed Jul 29, 2025

View reviewed changes

ui/src/views/infra/AddSecondaryStorage.vue Show resolved Hide resolved

sureshanaparti requested a review from vishesh92 July 29, 2025 04:12

sureshanaparti assigned DaanHoogland Jul 29, 2025

sureshanaparti requested a review from DaanHoogland July 29, 2025 04:12

shwstppr linked an issue Jul 29, 2025 that may be closed by this pull request

Exception is thrown when adding Swift as a secondary storage #9789

Closed

DaanHoogland approved these changes Jul 29, 2025

View reviewed changes

sureshanaparti approved these changes Jul 29, 2025

View reviewed changes

sureshanaparti assigned kiranchavala Jul 30, 2025

kiranchavala reviewed Jul 31, 2025

View reviewed changes

shwstppr added a commit to shapeblue/cloudstack that referenced this pull request Aug 4, 2025

plugin-swift: handle null cache store

eee40a1

Fixes apache#11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr mentioned this pull request Aug 4, 2025

plugin-swift: handle null cache store #11380

Merged

14 tasks

sureshanaparti added this to the 4.19.4 milestone Aug 4, 2025

kiranchavala approved these changes Aug 4, 2025 •

edited

Loading

View reviewed changes

shwstppr marked this pull request as ready for review August 4, 2025 10:40

sureshanaparti pushed a commit that referenced this pull request Aug 4, 2025

plugin-swift: handle null cache store (#11380)

3134efb

Fixes #11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

sureshanaparti merged commit a0fd37f into apache:4.19 Aug 4, 2025
25 checks passed

sureshanaparti deleted the ui-swiftstore-optionstoragepolicy branch August 4, 2025 10:56

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025

plugin-swift: handle null cache store (apache#11380)

882a98a

Fixes apache#11315 (review) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025

ui: pass validated storagepolicy for swift store (apache#11315)

40eedb6

Fixes apache#9789 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland removed their assignment Dec 24, 2025

Conversation

shwstppr commented Jul 29, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jul 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Jul 30, 2025

Uh oh!

DaanHoogland commented Jul 30, 2025

Uh oh!

sureshanaparti commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kiranchavala commented Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jul 29, 2025 •

edited

Loading

shwstppr commented Aug 4, 2025 •

edited

Loading